Test twap poll validate

cowprotocol / cow-sdk

CoW protocol SDK

https://docs.cow.fi/cow-protocol/reference/sdks/cow-sdk

Other

31 stars 9 forks source link

Test twap poll validate #168

Closed anxolin closed 12 months ago

anxolin commented 1 year ago

This PR test the “poll validate” logic, which is how the abstract order asks the concrete order to validate. The tests will cover the cases where:

The order has not started: It will instruct Watch Tower to wait until the correct start time
The order has expired: It will instruct the Watch Tower to not poll again this order. Expired orders, won’t yield a valid order since it is a final state
It also asserts the logic of not passing the blockInfo, so it uses the latest block info

Test

yarn test

coveralls commented 1 year ago

coverage: 76.427% (+1.4%) from 75.063% when pulling 6d5fec8c8c0e405abc51f0611fe39dfea1b50b93 on test-twap-poll-validate into 2ca4e6bd98f0e6dc34393f5eaa46e8612d91b972 on main.

github-actions[bot] commented 1 year ago

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

I have read the CLA Document and I hereby sign the CLA

_{You can retrigger this bot by commenting recheck in this Pull Request}

anxolin commented 12 months ago

No need to request changes as I see the math changes are in https://github.com/cowprotocol/cow-sdk/pull/169

Yep, this is why is good to do the unit tests :P Good eye