github-actions[bot]
commented
12 months ago CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.
I have read the CLA Document and I hereby sign the CLA
You can retrigger this bot by commenting recheck in this Pull Request
coveralls
socket-security[bot]
mfw78
This PR tries to close the SDK release v3.0.0
For that, I'm ensuring the Tenderly Watch Tower project works great with this version.
This PR does some small MISC in order to consider 3.0.0 ready!
Fix compute UID
The compute UID was not working. The struct needs be converted into an order (mapping some fields).
From struct to order + Tests
Created some util to convert order structs to orders.
Additionally, I did some unit test for it.
Improves the toString
toString is traditionally used to ready in the logs the details of the object. I felt it was a bit hard to read the older version, plus logging tools have a harder time parsing the values to make it easier to search
Also, the toString was not including some fields, like the receiver or the appData.
For this reason, I modified the implementation to serialise a JSON describing the TWAP:
Before:
After:
Added more tests for the TWAP toString
It tests the basic default, and setting custom start time, and limiting the duration.
Close version v3.0.0
This PR version will be tagged as v3.0.0
Test
I tried this PR against watch tower (this is how i found so many issues!
Now all looks SOLID ✅!