search

cowprotocol / cow-sdk

CoW protocol SDK
https://docs.cow.fi/cow-protocol/reference/sdks/cow-sdk
Other
31 stars 9 forks source link

Add id in to toSting method #171

Closed anxolin closed 11 months ago

anxolin commented 11 months ago

The Conditional Order id is super important piece of data, I think it should be part of the toString method.

This PR adds it.

Also, it adds some tests for the ID method in the TWAP order.

image
github-actions[bot] commented 11 months ago

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

I have read the CLA Document and I hereby sign the CLA

You can retrigger this bot by commenting recheck in this Pull Request

coveralls commented 11 months ago

Coverage Status

coverage: 78.445% (-0.7%) from 79.121% when pulling a5c2e6517cd9f1389c33b9882308db9a2971da7c on add-id-in-toString into f5c5d40913aedb8cc2072debab75190668aa9745 on main.