search

cowprotocol / cow-sdk

CoW protocol SDK
https://docs.cow.fi/cow-protocol/reference/sdks/cow-sdk
Other
31 stars 9 forks source link

feat(orderbook-api): order solution status #216

Closed alfetopito closed 1 month ago

alfetopito commented 1 month ago

Summary

Add getOrderSolutionStatus to orderbook api.

Based on types generated from openapi definition on https://github.com/cowprotocol/services/pull/2804

~TODO: update once backend merge/releases the PR~ merged, good to go!

https://barn.api.cow.fi/docs/#/default/get_api_v1_orders__UID__status

socket-security[bot] commented 1 month ago

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSourceCI
Install scripts npm/web3@1.10.3
  • Install script: postinstall
  • Source: echo "Web3.js 4.x alpha has been released for early testing and feedback. Checkout doc at https://docs.web3js.org/ "
 🚫
Install scripts npm/web3-bzz@1.10.3
  • Install script: postinstall
  • Source: echo "WARNING: the web3-bzz api will be deprecated in the next version"
 🚫
Install scripts npm/web3-shh@1.10.3
  • Install script: postinstall
  • Source: echo "WARNING: the web3-shh api will be deprecated in the next version"
 🚫

View full report↗︎

Next steps

What is an install script?

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore npm/web3@1.10.3
  • @SocketSecurity ignore npm/web3-bzz@1.10.3
  • @SocketSecurity ignore npm/web3-shh@1.10.3
coveralls commented 1 month ago

Coverage Status

coverage: 79.409% (-0.2%) from 79.583% when pulling f026389cc896557ea3ab3ae380d80dc23e2517e9 on feat/order-solution-status into 97d03154bbc8ef47c218bef57dbf518f41dd3a10 on main.

socket-security[bot] commented 1 month ago

Report too large to display inline

View full report↗︎

alfetopito commented 1 month ago

Please post merge review