search

cowprotocol / cowswap

🐮 CowSwap: First CoW Protocol UI
https://swap.cow.fi/
GNU General Public License v3.0
122 stars 92 forks source link

Expiry field in Order receipt #1762

Open elena-zh opened 1 year ago

elena-zh commented 1 year ago

Reported in https://cowservices.slack.com/archives/C0361CDG8GP/p1671446909118299

Need to change Expiry to execution date for filled limit order receipt image.png

Cancelled order: show cancelled date (if possible). Otherwise hide the field Expired order: no changes Failed order: no changes Open order: no changes Signing order: no changes Cancelling order: no changes

anxolin commented 1 year ago

@nenadV91 can you look at this one?

nenadV91 commented 1 year ago

As far as I can see, we don't have execution time in API response. Also does it makes sense to change this at all?

anxolin commented 1 year ago

As far as I can see, we don't have execution time in API response.

We should have :) I think its relevant. We can see if the backend has this info already, and can expose it. If not, we can always use the txHash to get the blockchain time (time of the block)

Also does it makes sense to change this at all?

As a user, I think it makes sense to know when your order was executed. The price you receive is very sensitive to that