search

cowprotocol / cowswap

🐮 CowSwap: First CoW Protocol UI
https://swap.cow.fi/
GNU General Public License v3.0
116 stars 87 forks source link

[1.35] Wrong approval modal appear when connected to Coinbase/Safe wallet #2409

Closed elena-zh closed 3 months ago

elena-zh commented 1 year ago

Edge case: the issue is reproducible when MM and Coinbase extensions are enabled in a browser.

To reproduce:

  1. Enable MM extension on Browser
  2. Enable Coinbase extnsion
  3. Connect to the Coinbase wallet (extension)
  4. Select a token with no allowance in the Sell field
  5. Enter an amount < balance
  6. Select a token to sell
  7. Press on the Allow button
  8. Check the modal

AR: modal for MM appears modal for coinbase.png

ER: regular modal appears image.png

elena-zh commented 1 year ago

The same issue is reproducible with Safe image