cowprotocol / cowswap

🐮 CowSwap: First CoW Protocol UI
https://swap.cow.fi/
GNU General Public License v3.0
110 stars 78 forks source link

[1.48.0] Unhandled errors in Permittable over Wallet Connect #3216

Open anxolin opened 8 months ago

anxolin commented 8 months ago

Description When i reject the permit of MAINNET DAI, i get this pretty message:

image

How to Reproduce

  1. In mainnet, connect your wallet (i used Wallet Connect)
  2. Start a swap DAI for sth (make sure you have no approval)
  3. Reject in your wallet

Expected behavior We should handle this 4001 error code as we do in other flows, and show a nicer message

additional data

{"code":4001,"message":"User rejected the request.","stack":"construct@[native code]\nconstruct@[native code]\no@/private/var/containers/Bundle/Application/1C558402-D9DD-4CB6-B414-0C6B89ED5176/MetaMask.app/main.jsbundle:57:332\nconstruct@[native code]\n@/private/var/containers/Bundle/Application/1C558402-D9DD-4CB6-B414-0C6B89ED5176/MetaMask.app/main.jsbundle:2066:162\no@/private/var/containers/Bundle/Application/1C558402-D9DD-4CB6-B414-0C6B89ED5176/MetaMask.app/main.jsbundle:2066:840\nconstruct@[native code]\n@/private/var/containers/Bundle/Application/1C558402-D9DD-4CB6-B414-0C6B89ED5176/MetaMask.app/main.jsbundle:2066:162\no@/private/var/containers/Bundle/Application/1C558402-D9DD-4CB6-B414-0C6B89ED5176/MetaMask.app/main.jsbundle:2066:1361\nt@/private/var/containers/Bundle/Application/1C558402-D9DD-4CB6-B414-0C6B89ED5176/MetaMask.app/main.jsbundle:2070:271\n@/private/var/containers/Bundle/Application/1C558402-D9DD-4CB6-B414-0C6B89ED5176/MetaMask.app/main.jsbundle:4090:7248\ngeneratorResume@[native code]\nc@/private/var/containers/Bundle/Application/1C558402-D9DD-4CB6-B414-0C6B89ED5176/MetaMask.app/main.jsbundle:4090:511\nu@/private/var/containers/Bundle/Application/1C558402-D9DD-4CB6-B414-0C6B89ED5176/MetaMask.app/main.jsbundle:69:158\n@/private/var/containers/Bundle/Application/1C558402-D9DD-4CB6-B414-0C6B89ED5176/MetaMask.app/main.jsbundle:69:870\n@/private/var/containers/Bundle/Application/1C558402-D9DD-4CB6-B414-0C6B89ED5176/MetaMask.app/main.jsbundle:75:1471\nT@/private/var/containers/Bundle/Application/1C558402-D9DD-4CB6-B414-0C6B89ED5176/MetaMask.app/main.jsbundle:75:419\np@/private/var/containers/Bundle/Application/1C558402-D9DD-4CB6-B414-0C6B89ED5176/MetaMask.app/main.jsbundle:75:692\ncallReactNativeMicrotasks@/private/var/containers/Bundle/Application/1C558402-D9DD-4CB6-B414-0C6B89ED5176/MetaMask.app/main.jsbundle:75:2871\nvalue@/private/var/containers/Bundle/Application/1C558402-D9DD-4CB6-B414-0C6B89ED5176/MetaMask.app/main.jsbundle:37:2875\n@/private/var/containers/Bundle/Application/1C558402-D9DD-4CB6-B414-0C6B89ED5176/MetaMask.app/main.jsbundle:37:966\nvalue@/private/var/containers/Bundle/Application/1C558402-D9DD-4CB6-B414-0C6B89ED5176/MetaMask.app/main.jsbundle:37:2511\nvalue@/private/var/containers/Bundle/Application/1C558402-D9DD-4CB6-B414-0C6B89ED5176/MetaMask.app/main.jsbundle:37:924\nvalue@[native code]\nvalue@[native code]"}
alfetopito commented 8 months ago

This also happens when rejecting an approval tx:

image