search

cowprotocol / cowswap

🐮 CowSwap: First CoW Protocol UI
https://swap.cow.fi/
GNU General Public License v3.0
108 stars 73 forks source link

feat: add devcontainer #4434

Closed anxolin closed 1 week ago

anxolin commented 2 weeks ago

Summary

@alfetopito maybe this helps you run the explorer or understand what is wrong

This PR lets you run it using devcontainers.

image

Don't merge

This PR should not be merged until we understand what's wrong with ethflow package in devcontainers This package is weird anyways, cause is not published in NPM, so I think that is messing up with devcotainers somehow

image

However, I can see the directory they complain about not existing:

image

vercel[bot] commented 2 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
cosmos 🔄 Building (Inspect) Visit Preview May 22, 2024 2:26pm
cowfi 🔄 Building (Inspect) Visit Preview May 22, 2024 2:26pm
explorer-dev 🔄 Building (Inspect) Visit Preview May 22, 2024 2:26pm
swap-dev 🔄 Building (Inspect) Visit Preview May 22, 2024 2:26pm
widget-configurator 🔄 Building (Inspect) Visit Preview May 22, 2024 2:26pm
socket-security[bot] commented 2 weeks ago

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@1inch/permit-signed-approvals-utils@1.4.10 None 0 65.8 kB 1inch-robot
npm/@apollo/client@3.8.8 network 0 5.97 MB apollo-bot
npm/@babel/runtime@7.22.6 None 0 282 kB nicolo-ribaudo
npm/@coinbase/wallet-sdk@3.7.1 environment 0 405 kB jungho.bang
npm/@cowprotocol/app-data@2.1.0 None 0 212 kB cowprotocol_dev
npm/@cowprotocol/cms@0.2.2 None 0 433 kB cowprotocol_dev
npm/@cowprotocol/contracts@1.4.0 network 0 2.19 MB cowprotocol_dev
npm/@cowprotocol/cow-runner-game@0.2.9 None 0 247 kB anxolin
npm/@cowprotocol/cow-sdk@5.0.0 network 0 1.1 MB cowprotocol_dev
npm/@cowprotocol/events@1.3.0 None 0 10.5 kB cowprotocol_dev
npm/@davatar/react@1.8.1 network 0 35.3 kB carlosdp
npm/@emotion/react@11.11.1 environment 0 584 kB emotion-release-bot
npm/@emotion/styled@11.11.0 environment 0 177 kB emotion-release-bot
npm/@ethersproject/experimental@5.7.0 None 0 94.3 kB ricmoo
npm/@fontsource/ibm-plex-mono@4.5.13 None 0 3.38 MB lotusdevshack
npm/@fontsource/inter@4.5.15 None 0 4.45 MB lotusdevshack
npm/@fortawesome/fontawesome-svg-core@6.5.1 None 0 398 kB robmadole
npm/@fortawesome/free-regular-svg-icons@6.5.1 None 0 684 kB robmadole
npm/@fortawesome/free-solid-svg-icons@6.5.1 None 0 5.08 MB robmadole
npm/@fortawesome/react-fontawesome@0.2.0 environment 0 37.4 kB robmadole
npm/@gnosis.pm/dex-js@0.10.0 environment 0 250 kB alfetopito
npm/@lingui/cli@4.10.0 None 0 117 kB andrii.bodnar
npm/@lingui/core@4.10.0 environment 0 49.2 kB andrii.bodnar
npm/@lingui/macro@4.10.0 environment 0 108 kB andrii.bodnar
npm/@lingui/react@4.10.0 environment 0 35.3 kB andrii.bodnar
npm/@material-ui/core@4.12.4 environment 0 5.96 MB eps1lon
npm/@metamask/eth-sig-util@5.1.0 None 0 150 kB metamaskbot
npm/@metamask/jazzicon@2.0.0 None 0 5.87 kB whymarrh
npm/@mui/icons-material@5.14.13 None 0 18.9 MB mj12albert
npm/@mui/lab@5.0.0-alpha.148 environment 0 1.38 MB mj12albert
npm/@mui/material@5.14.13 environment 0 10.2 MB mj12albert
npm/@reach/dialog@0.18.0 environment 0 53.3 kB chancestrickland
npm/@reach/menu-button@0.18.0 environment 0 46.9 kB chancestrickland
npm/@reach/portal@0.18.0 environment 0 20.7 kB chancestrickland
npm/@react-hook/window-scroll@1.3.0 None 0 22.3 kB jaredlunde
npm/@react-spring/web@9.7.3 environment 0 158 kB tdfka_rick
npm/@reduxjs/toolkit@1.9.5 environment 0 12.9 MB acemarke
npm/@rjsf/core@4.2.3 environment 0 4.86 MB rjsf-bot
npm/@safe-global/api-kit@1.3.0 None 0 115 kB germartinez
npm/@safe-global/protocol-kit@1.2.0 None 0 1.91 MB germartinez
npm/@safe-global/safe-core-sdk-types@2.2.0 None 0 65.4 kB germartinez
npm/@safe-global/safe-ethers-lib@1.9.4 None 0 766 kB germartinez
npm/@sentry/react@7.80.0 None 0 274 kB sentry-bot
npm/@sentry/tracing@7.80.0 None 0 81.2 kB sentry-bot
npm/@sentry/webpack-plugin@2.10.0 None 0 66.1 kB sentry-bot
npm/@swc/helpers@0.5.11 None 0 235 kB kdy1
npm/@tanstack/react-virtual@3.0.2 None 0 182 kB tannerlinsley
npm/@trezor/connect-plugin-ethereum@9.0.1 None 0 9.38 kB trezor-ci
npm/@trezor/connect-web@9.0.11 None 0 55.6 kB trezor-ci
npm/@types/hdkey@2.0.1 None 0 5.04 kB types
npm/@uniswap/sdk-core@3.2.6 environment 0 297 kB cbachmeier
npm/@uniswap/token-lists@1.0.0-beta.33 environment 0 113 kB lynnshaoyu
npm/@use-gesture/react@10.2.27 environment 0 37.7 kB dbismut
npm/@visx/axis@3.10.1 None 0 72.4 kB christopher.card.williams
npm/@visx/event@3.3.0 None 0 16.1 kB christopher.card.williams
npm/@visx/glyph@3.3.0 None 0 53.3 kB christopher.card.williams
npm/@visx/responsive@3.10.2 None 0 57.8 kB christopher.card.williams
npm/@visx/shape@3.5.0 None +1 299 kB christopher.card.williams
npm/@walletconnect/ethereum-provider@2.10.2 None 0 3.08 MB gancho_walletconnect
npm/@web3-react/coinbase-wallet@8.2.3 None 0 59.8 kB towering-elsie
npm/@web3-react/core@8.2.3 None 0 67.6 kB towering-elsie
npm/@web3-react/eip1193@8.2.3 None 0 43.1 kB towering-elsie
npm/@web3-react/empty@8.2.3 None 0 37.1 kB towering-elsie
npm/@web3-react/gnosis-safe@8.2.4 None 0 48.7 kB towering-elsie
npm/@web3-react/metamask@8.2.4 None 0 60.1 kB towering-elsie
npm/@web3-react/network@8.2.3 None 0 50.7 kB towering-elsie
npm/@web3-react/url@8.2.3 None 0 42.8 kB towering-elsie
npm/@web3-react/walletconnect-v2@8.5.1 None 0 65.1 kB towering-elsie
npm/@web3modal/ethers5@4.1.9 None 0 85 kB svenvoskamp
npm/bnc-sdk@4.6.7 None 0 659 kB cmeisl
npm/buffer@6.0.3 None 0 91.3 kB feross
npm/cids@1.1.9 None 0 40.8 kB achingbrain
npm/clone-deep@4.0.1 None 0 8 kB jonschlinkert
npm/color2k@2.0.2 None 0 291 kB ricokahler
npm/combine-reducers@1.0.0 None 0 3.34 kB wesleytodd
npm/console-feed@3.5.0 None 0 248 kB samdd
npm/copy-to-clipboard@3.3.3 None 0 15.1 kB sudodoki
npm/cross-env@7.0.3 environment 0 29.1 kB kentcdodds
npm/cytoscape-fcose@2.2.0 None 0 8.68 MB ivisatbilkent
npm/cytoscape-klay@3.1.4 None 0 77.8 kB maxkfranz
npm/cytoscape-no-overlap@1.0.1 None 0 214 kB martinheon
npm/cytoscape-popper@2.0.0 None 0 35 kB maxkfranz
npm/cytoscape@3.28.1 None 0 4.45 MB maxkfranz
npm/d3@7.8.5 None 0 873 kB mbostock
npm/date-fns@2.30.0 None 0 6.69 MB kossnocorp
npm/ethers@5.7.2 None 0 10.7 MB ricmoo

🚮 Removed packages: npm/@babel/compat-data@7.23.5, npm/@babel/helper-environment-visitor@7.22.20, npm/@babel/helper-plugin-utils@7.22.5, npm/@babel/helper-string-parser@7.24.1, npm/@babel/helper-validator-identifier@7.24.5, npm/@babel/parser@7.24.5, npm/@cowprotocol/ethflowcontract@1.1.1, npm/@emotion/stylis@0.8.5, npm/@eslint/js@8.57.0, npm/@humanwhocodes/object-schema@2.0.3, npm/@istanbuljs/schema@0.1.3, npm/@jridgewell/resolve-uri@3.1.2, npm/@jridgewell/set-array@1.2.1, npm/@jridgewell/sourcemap-codec@1.4.15, npm/@nodelib/fs.stat@2.0.5, npm/@rushstack/eslint-patch@1.10.2, npm/@swc/counter@0.1.3, npm/@types/d3-color@3.1.0, npm/@types/d3-time@3.0.0, npm/@types/istanbul-lib-coverage@2.0.4, npm/@types/json-schema@7.0.15, npm/@ungap/structured-clone@1.2.0, npm/abab@2.0.6, npm/acorn@8.11.3, npm/address@1.2.2, npm/ast-types-flow@0.0.8, npm/axe-core@4.7.0, npm/base64-js@1.5.1, npm/bluebird@3.7.2, npm/boolbase@1.0.0, npm/brorand@1.1.0, npm/camelcase@6.3.0, npm/clsx@1.2.1, npm/color-name@1.1.4, npm/colord@2.9.3, npm/colorette@2.0.20, npm/confusing-browser-globals@1.0.11, npm/content-type@1.0.5, npm/core-js-pure@3.35.0, npm/css-what@6.1.0, npm/d3-color@3.1.0, npm/d3-ease@3.0.1, npm/d3-format@3.1.0, npm/d3-path@1.0.9, npm/d3-timer@3.0.1, npm/decamelize@1.2.0, npm/decimal.js@10.4.3, npm/decode-uri-component@0.2.2, npm/deepmerge@4.3.1, npm/depd@2.0.0, npm/dequal@2.0.3, npm/diff-sequences@29.6.3, npm/entities@4.5.0, npm/es-errors@1.3.0, npm/esprima@4.0.1, npm/estraverse@5.3.0, npm/events@3.3.0, npm/extend@3.0.2, npm/fast-deep-equal@3.1.3, npm/fast-json-stable-stringify@2.1.0, npm/flatted@3.3.1, npm/fraction.js@4.2.0, npm/fsevents@2.3.2, npm/functions-have-names@1.2.3, npm/get-caller-file@2.0.5, npm/graceful-fs@4.2.11, npm/has-symbols@1.0.3, npm/ieee754@1.2.1, npm/inherits@2.0.4, npm/internmap@2.0.3, npm/is-callable@1.2.7, npm/is-docker@2.2.1, npm/is-map@2.0.2, npm/is-negative-zero@2.0.3, npm/is-path-inside@3.0.3, npm/is-plain-obj@1.1.0, npm/is-set@2.0.2, npm/is-typedarray@1.0.0, npm/istanbul-lib-coverage@3.2.0, npm/js-sha3@0.8.0, npm/js-tokens@4.0.0, npm/json-parse-even-better-errors@2.3.1, npm/json-schema@0.4.0, npm/json5@2.2.3, npm/kind-of@6.0.3, npm/klona@2.0.6, npm/language-subtag-registry@0.3.22, npm/lodash.memoize@4.1.2, npm/lodash@4.17.21, npm/merge2@1.4.1, npm/mime-db@1.52.0, npm/mime@1.6.0, npm/minimalistic-assert@1.0.1, npm/minimist@1.2.8, npm/ms@2.1.3, npm/nanoid@3.3.7, npm/node-releases@2.0.14, npm/normalize-path@3.0.0, npm/nwsapi@2.2.7, npm/object-assign@4.1.1, npm/object-inspect@1.13.1, npm/parseurl@1.3.3, npm/path-parse@1.0.7, npm/picomatch@2.3.1, npm/pirates@4.0.6, npm/postcss-value-parser@4.2.0, npm/prettier@2.8.8, npm/pretty-bytes@5.6.0, npm/psl@1.9.0, npm/q@1.5.1, npm/range-parser@1.2.1, npm/react-is@18.2.0, npm/regenerator-runtime@0.13.11, npm/resolve-from@5.0.0, npm/resolve.exports@1.1.0, npm/safe-buffer@5.2.1, npm/safer-buffer@2.1.2, npm/setimmediate@1.0.5, npm/shell-quote@1.8.1, npm/signal-exit@4.1.0, npm/source-map-js@1.0.2, npm/strip-json-comments@3.1.1, npm/svg-parser@2.0.4, npm/tapable@2.2.1, npm/through@2.3.8, npm/type-detect@4.0.8, npm/unpipe@1.0.0, npm/util-deprecate@1.0.2, npm/vary@1.1.2, npm/web-vitals@2.1.4, npm/webpack-sources@3.2.3, npm/xtend@4.0.2, npm/yallist@4.0.0, npm/yaml@1.10.2, npm/yargs-parser@21.1.1

View full report↗︎

socket-security[bot] commented 2 weeks ago

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSource
Install scripts npm/@fortawesome/fontawesome-svg-core@6.5.1
  • Install script: postinstall
  • Source: node attribution.js
Install scripts npm/@fortawesome/free-regular-svg-icons@6.5.1
  • Install script: postinstall
  • Source: node attribution.js
Install scripts npm/@fortawesome/free-solid-svg-icons@6.5.1
  • Install script: postinstall
  • Source: node attribution.js

View full report↗︎

Next steps

What is an install script?

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore npm/@fortawesome/fontawesome-svg-core@6.5.1
  • @SocketSecurity ignore npm/@fortawesome/free-regular-svg-icons@6.5.1
  • @SocketSecurity ignore npm/@fortawesome/free-solid-svg-icons@6.5.1
alfetopito commented 2 weeks ago

I can build and run the explorer* and cowswap fine with the dev container without the issue you are facing AFTER I revert the package.json changes.

`* by fine I mean, the same way as without the dev container: it starts but I can't open it