cowprotocol / cowswap

🐮 CowSwap: First CoW Protocol UI
https://swap.cow.fi/
GNU General Public License v3.0
122 stars 92 forks source link

fix(explorer): make sure txHash always has the 0x prefix #5061

Closed alfetopito closed 1 week ago

alfetopito commented 1 week ago

Summary

Make sure txHash on transaction view always has the 0x prefix

To Test

  1. Search for a transaction hash without the 0x prefix
    • Should load as usual
    • Link to etherscan should work
vercel[bot] commented 1 week ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
cosmos ✅ Ready (Inspect) Visit Preview Nov 5, 2024 1:46pm
cowfi ✅ Ready (Inspect) Visit Preview Nov 5, 2024 1:46pm
explorer-dev ✅ Ready (Inspect) Visit Preview Nov 5, 2024 1:46pm
swap-dev ✅ Ready (Inspect) Visit Preview Nov 5, 2024 1:46pm
widget-configurator ✅ Ready (Inspect) Visit Preview Nov 5, 2024 1:46pm
alfetopito commented 1 week ago

I works!

But now I have a separate quesiton: why search for a TX hash without 0x works fine while it does not for an order id? :) image

Historical reasons (I don't know, basically)