search

cowprotocol / cowswap

🐮 CowSwap: First CoW Protocol UI
https://swap.cow.fi/
GNU General Public License v3.0
122 stars 92 forks source link

CSS broken on Limit Order #5084

Open greenlucid opened 1 day ago

greenlucid commented 1 day ago

To reproduce:

  1. Open Limit orders page
  2. Connect to a wallet
  3. Fill in a Sell token
  4. Pick a LP token that is currently not supported on the UI ( I picked 0xfcd125f4c5030137634863A2d3E5d6D89158f19C on Gnosis chain)
  5. Start typing a price ---> you will get this screen

Cannot even click the X on the green popup image

image
greenlucid commented 1 day ago

Swapping the tokens out of order fixes the style. I'd guess the issue is that the symbol length of the token you're buying, was too long. The error only occurs when the long-symbol token is intended to be bought

elena-zh commented 1 day ago

Looks like the same issue as #4867

greenlucid commented 1 day ago

Good catch, slightly different since that one is about typing in the field. I cannot reproduce it that way. Might be two different issues at the same time (unbounded size on the token picker, and unbounded size on the amount input form)

elena-zh commented 1 day ago

There are different ways to reproduce this issue, but in terms of the CSS the issue is the same: the UI expands on invalid price/quote. I've added steps to reproduce to the issue description and will let the team know about it.