cowprotocol / docs

Developer Documentation 🐮📖🤓

https://docs.cow.fi

GNU Lesser General Public License v3.0

4 stars 12 forks source link

Closed fleupold closed 9 months ago

fleupold commented 10 months ago

We have a bunch of known low pri smart contract issues that should be mentioned to avoid confusion with potential bug bounty claims. Namely

[x] ERC1271 replay for poor smart contract implementations
- [x] Port security-related page to new docs
[x] domain_verifier is not "fork-proof" (e.g. the ETHPOW settlement contract, has the same verifier as mainnet)
[x] Missing security notes on sellAmount / buyAmount = 0

fleupold commented 9 months ago

I saw a PR regarding this. Has this been merged? Can it be closed?

mfw78 commented 9 months ago

229 is still open for comment 🙂