cowprotocol / docs

Developer Documentation 🐮📖🤓
https://docs.cow.fi
GNU Lesser General Public License v3.0
4 stars 14 forks source link

feat(widget): update partner fee #343

Closed alfetopito closed 8 months ago

alfetopito commented 8 months ago

Description

Add partner fee docs as defined here

Changes

vercel[bot] commented 8 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Mar 26, 2024 2:38pm
elena-zh commented 8 months ago

Hey @alfetopito , great, thank you! Some nitpicks from my side:

  1. I'd remove the link from 'the' here remove from the
  2. (not sure), here should be the anchor link, correct? Or 'refer' text in brackets means that 'Net Partner Fee' should be the link? link2
  3. was going to report that here also should be the link, but you changed the text a bit, and it is not needed (indeed). link is missing

Thanks!

alfetopito commented 8 months ago

Hey @alfetopito , great, thank you! Some nitpicks from my side:

1. I'd remove the link from 'the' [here](https://docs-git-feat-update-partner-fee-cowswap.vercel.app/governance/fees#partner-fee)
   ![remove from the](https://private-user-images.githubusercontent.com/70885163/316782799-e8b0b1c1-28a8-4d10-bb57-015971f9cde1.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTE0NDIzMDcsIm5iZiI6MTcxMTQ0MjAwNywicGF0aCI6Ii83MDg4NTE2My8zMTY3ODI3OTktZThiMGIxYzEtMjhhOC00ZDEwLWJiNTctMDE1OTcxZjljZGUxLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDAzMjYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwMzI2VDA4MzMyN1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPThhMTU4YWMyMzVmYzhkZjNlYmZkNWJhMDIxZjk3ZjY1ZTY3OTA3YmY2ZDVhYzYwYmQyNGZjZDI4ZTFjYTNiNmImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.HW7ouo5s0nB_JaN7-NciTKOfGJwoENqjsErJiLKvS1s)

2. (not sure), here should be the anchor link, correct? Or 'refer' text in brackets means that 'Net Partner Fee' should be the link?
   ![link2](https://private-user-images.githubusercontent.com/70885163/316782993-70b83cbf-680d-4a71-9f6f-ae0329d03b83.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTE0NDIzMDcsIm5iZiI6MTcxMTQ0MjAwNywicGF0aCI6Ii83MDg4NTE2My8zMTY3ODI5OTMtNzBiODNjYmYtNjgwZC00YTcxLTlmNmYtYWUwMzI5ZDAzYjgzLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDAzMjYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwMzI2VDA4MzMyN1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTBiNTA3ODgwMGZiNDAwN2FkYjYwYjVmMjdmNWQxMTdlODdlYTdhN2QxZDY2YTkwNmQwNGFlODYzZmExOTA1MzMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.c2DY3YOYwgiKvWTSmWCHdCxYAr0WdKVpfSfIjbZoPoY)

3. was going to report that here also should be the link, but you changed the text a bit, and it is not needed (indeed).
   ![link is missing](https://private-user-images.githubusercontent.com/70885163/316783101-7cbc686b-a42b-4239-973f-c2663f42dc77.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTE0NDIzMDcsIm5iZiI6MTcxMTQ0MjAwNywicGF0aCI6Ii83MDg4NTE2My8zMTY3ODMxMDEtN2NiYzY4NmItYTQyYi00MjM5LTk3M2YtYzI2NjNmNDJkYzc3LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDAzMjYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwMzI2VDA4MzMyN1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWNhN2IzNDVhZTE2MTE4M2VlMGUyYzNjNTU5YTY1YTkyNzg0ZmQyNjRmZjY2MDk2M2VjMDQwMzZhOGQ1OTUyNmEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.GSvctitf7JxvQ11_rP_5AVFSs2lBv7Yw5gB5Ca4-SJA)

Thanks!

Done

alfetopito commented 8 months ago

It's a standard within the docs to always use typewriter apostrophes and quotes to allow for standardisation.

Agreed, removed the bad ones.