search

cowprotocol / dune-bridge

Other
4 stars 3 forks source link

[Refactor] Improve Performance & Remove Daily #1

Closed nlordell closed 2 years ago

nlordell commented 2 years ago

This PR changes the build_query_for_affiliate_data to no longer require date bounds by making use of the trade_view. This view allows us to fetch all trades and their valuations in seconds - thus eliminating the need for daily updates in favour of all time query without wait time.

We rename a few files (for simplicity) to adapt to this change as removing the faily eliminates the need for overly verbose file names.

POC query can be found here -- whose most recent execution time was 10 seconds.

Note that this change will also require updating the pods which expect certain scripts to be available which have been deleted.

Original PR gnosis/gp-dune-bridge#62 by @bh2smith

bh2smith commented 2 years ago

This is so old, its never gonna land. Closing however this does still need to happen.