search

cowprotocol / dune-bridge

Other
4 stars 3 forks source link

[Retention] exit when start > end #23

Closed bh2smith closed 1 year ago

bh2smith commented 2 years ago

Earlier we saw in our pod logs (because I was testing and running the script every minute instead of every day like it should) that the program prints something weird when its already updated:

$ kubectl logs dev-dfusion-user-retention-cj-v10-27647277-sd6sw
Fetching Retention from 2022-07-26 to 2022-07-25 (yesterday)
User Retention successfully updated: https://dune.xyz/queries/1103196

Notice from date is greater than to date in logs.

TODO

Also I should take this opportunity to use proper logging here.

bh2smith commented 1 year ago

Probably never gonna do this.

bh2smith commented 1 year ago

Wait - its already done and has been open since JULY. Wen merge?

bh2smith commented 1 year ago

This is a very small hiccup in the retention fetching program that doesn't really matter if it gets merged or not. Even though it is several months old and still has no conflicts I will merge it... YOLO!