search

cowprotocol / dune-bridge

Other
4 stars 3 forks source link

Dune Query Instantantiation Change #27

Closed bh2smith closed 2 years ago

bh2smith commented 2 years ago

Due to recent changes in the Dune API, the parameters provided to instantiate a Dune query have been simplified.

The error we were seeing was due to a lack of explicit parameter names.

I will be adding a follow up PR to introduce type checking (this is what would have caught this issue). however, I didn't want to introduce it here, because it would make the PR far too bulky and had to read.

nlordell commented 2 years ago

I will be adding a follow up PR to introduce type checking (this is what would have caught this issue). however, I didn't want to introduce it here, because it would make the PR far too bulky and had to read.

🙌

bh2smith commented 2 years ago

I think the error could have also been caught if python would check for unused variables

Usually it would. I am actually not sure why it wasn't in this case!