cowprotocol / dune-bridge

Other
4 stars 3 forks source link

Migrate Reusable Code to dune-client #40

Open bh2smith opened 1 year ago

bh2smith commented 1 year ago

Several pieces introduced in #37 can be refined, generalized and moved into the dependency package dune-cli

In particular:

There are a few reasons why these have not yet been moved into the client outlined here. But, in essence, it is because they need to be refined a bit more before we can make then serve as a useful general purpose. For example, it isn't clear that either of QueryData or DuneFetcher are all that beneficial -- perhaps its better to just extend the Query and DuneClient classes to include the additional fields added in these "extended classes". Would love to open up a discussion about this (maybe in the Dune Client).