search

cowprotocol / dune-sync

Components for syncing off-chain data with Dune Community Sources
4 stars 1 forks source link

Ignore failing test #70

Closed harisang closed 9 months ago

harisang commented 9 months ago

This PR removes a failing IPFS test, as reported in issue #60 . Although it would be nice to fix, we don't really have the capacity for this now, and so i am proposing to remove this test so that we don't get constant failures in all the PRs that we are doing at the moment.

UPDATE: We followed @bh2smith 's suggestion and just ignored the test for now instead of removing it.

bh2smith commented 9 months ago

You could just put an ignore/skip tag on the test with a todo and corresponding issue to get back to it.

bh2smith commented 9 months ago

If this test is consistently failing, this seems to suggest that the only source of truth now is the Dune table. If it were wiped, we might not be able to recreate that record...

This Dune query, shows the record we expect to find on IPFS:

https://dune.com/queries/3381890

The failing tests seems to imply that this record is no longer available on IPFS.