search

cowprotocol / dune-sync

Components for syncing off-chain data with Dune Community Sources
4 stars 1 forks source link

make volume fee code identical to code in solver-rewards repo #77

Closed fhenneke closed 9 months ago

fhenneke commented 9 months ago

This code change makes the code to compute volume based protocol fees identical to the code in the solver-rewards repo.

Potentially the implementation is not consistent to what will be done in the driver. Since volume based fees are not used in production yet this is not much of an issue for now.

I am also not super sure if we might need different cases for sell and buy orders. In any case, since we only test those queries in the solver rewards repo we should make the code consitsant with said repo.

harisang commented 9 months ago

Approving for consistency but we need to revisit this. There is already an open issue on the solver-rewards repo about this.