search

cowprotocol / dune-sync

Components for syncing off-chain data with Dune Community Sources
4 stars 1 forks source link

[Mirror] Add price improvement protocol fee #92

Closed fhenneke closed 5 months ago

fhenneke commented 5 months ago

This PR mirrors the changes from https://github.com/cowprotocol/solver-rewards/pull/353.

Besides introducing price improvement fees, mirroring the changes from solver-rewards fixed some issues in order rewards.

harisang commented 5 months ago

fixed some issues in order rewards.

Can you elaborate on what was the issue that was fixed here?

fhenneke commented 5 months ago

I added a PR in solver-rewards on changing details of those SQL queries: https://github.com/cowprotocol/solver-rewards/pull/354

harisang commented 5 months ago

Seems i merged it although some test was failing. Sorry, misread what was failing and thought it was for another reason. PR #93 addresses this.