search

cowprotocol / ethcontract-rs

Generate type-safe bindings for interacting with Ethereum contracts.
Apache License 2.0
307 stars 45 forks source link

Hardhat support probably shouldn't depend on hardhat-deploy #731

Open banshee opened 2 years ago

banshee commented 2 years ago

Looking at the hardhat config in examples/hardhat/hardhat.config.js, you start with:

require("hardhat-deploy");

That seems a bit unusual; we certainly use hardhat, but we took a quick look at hardhat-deploy and decided it wasn't necessary. I guess it makes sense to support hardhat-deploy in addition to the mainstream, but it shouldn't be a requirement.

banshee commented 2 years ago

Looking deeper at the code, I think the hardhat support is just misnamed; it's really support for hardhat-deploy and not for hardhat at all. Things like fn _load_from_directory talk about directory structures that are completely different from normal hardhat.