cowprotocol / ethcontract-rs

Generate type-safe bindings for interacting with Ethereum contracts.
Apache License 2.0
307 stars 45 forks source link

Fix build #926

Closed fleupold closed 1 year ago

fleupold commented 1 year ago

Fixes CI

A few issues are preventing the KMS PR to build (completely unrelated to that feature), so it probably makes sense to isolate those changes:

  1. Min supported rust version now seems to be 1.65 now
  2. There seems to be a clippy false negative wrt unnecessary clones (can repro locally on cargo v1.70). Fix is to ignore the warning
  3. Ganache is violating the strict JSON RPC serialisation, mixing error and success fields in its response (and on newer versions even mingling more unknown fields) image

Fix is to use foundry anvil

This requires changes in the github actions and subtle changes in the example (different chain_id, handing invalid opcode responses slightly differently)

Test Plan

CI passing 🤞