cowprotocol / explorer

https://explorer.cow.fi/

12 stars 8 forks source link

feat: env var for custom order-book API urls #698

Closed shoom3301 closed 9 months ago

shoom3301 commented 10 months ago

Summary

The order-book API endpoint is configured using the environment variable REACT_APP_ORDER_BOOK_URLS

vercel[bot] commented 10 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
explorer-dev	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 25, 2023 8:45am

github-actions[bot] commented 10 months ago

Pull Request Test Coverage Report for Build 7285728193

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 61.711%

Totals
Change from base Build 7248021046:	0.0%
Covered Lines:	878
Relevant Lines:	1237

💛 - Coveralls

shoom3301 commented 10 months ago

@alfetopito thank you! Added the var into webpack config, tested, it works.

is it possible to pass to the SDK (like the settings above) prod & barn api endpoints? No, but I understand why you asking. We use getOrderMultiEnv in Explorer. I will try to add a configuration for this case in the next PR.

shoom3301 commented 10 months ago

@alfetopito sure! Remove the unused code

shoom3301 commented 9 months ago

https://github.com/cowprotocol/cowswap/pull/3584 The PR was migrated to the new repo