cowprotocol / solver-rewards

Data Aggregation for Solver Reimbursement & Rewards Distributor
Other
8 stars 5 forks source link

Change use of block deadlines #381

Closed fhenneke closed 2 months ago

fhenneke commented 2 months ago

This PR adds a grace period of one block to the deadline for settling on chain. It also removes the use of block deadlines in computing fees and other quantities.

The PR changes two things:

The estimated impact on solver from adding a grace period is an increase in overall rewards by about 1.48 ETH in the accounting period 2024-08-06--2024-08-13. The impact of the second change on slippage is not estimated precisely. The overcharging of protocol fees amounts to 0.6 ETH. The missing reimbursement of network fees is not estimated. See this Dune query.

The changes should be mirrored to dune-sync and data for the accounting period starting on 2024-08-13 should be re-synced.

fhenneke commented 2 months ago

Comparing the total performance rewards with this PR to the actual payouts for the last accounting period gives

Actual COW needed: 343097.8722
Actual ETH needed: 85.9442

New COW needed: 358344.1259
New ETH needed: 86.8461

Difference COW: 15246.2537 (around 1.19 ETH)
Difference ETH: 0.9019

The the estimates based on the Dune are somewhat accurate.