search

cowprotocol / solver-template-py

A hollow framework for a CoW Protocol solver
MIT License
40 stars 26 forks source link

Concentrated Liquidity schema not defined. Returns "value is not a valid enumeration member" #19

Open mohammed7s opened 2 years ago

mohammed7s commented 2 years ago

When attempting to run the solver-template-py with a recent live mainnet auction json, it returns a bunch of errors:

This is because the uniswap class in uniswap.py and the schema.py have not defined this type of AMM yet.

bh2smith commented 2 years ago

Great issue! Thanks for reporting. Any chance you'd like to submit a update to support such liquidity type?

mohammed7s commented 2 years ago

Do you think the class Uniswap in uniswap.py, can handle it with some changes? Or you think a new class is needed altogether?

bh2smith commented 2 years ago

Do you think the class Uniswap in uniswap.py, can handle it with some changes? Or you think a new class is needed altogether?

That is a great question. I am not familiar with this new liquidity type "concentrated liquidity" (my best guess is that it's a model for uniV3). Perhaps it's time for some new models here. cc @marcovc