search

cowprotocol / token-imbalances

2 stars 0 forks source link

Revert #64 #66

Closed fhenneke closed 1 month ago

fhenneke commented 1 month ago

The change from #64 to add additional price feeds broke an assumtion of the slippage prices table.

The slippage_prices table has (tx_hash, token_address) as primary key. This is incompatible with having multiple prices per token and transaction.

The talbe layout should be changed.

bram-vdberg commented 1 month ago

LGTM, do we need to rerun something to fix the data from the past 2 hours?

fhenneke commented 1 month ago

LGTM, do we need to rerun something to fix the data from the past 2 hours?

The code should work hopefully work fine after the revert. The failed writes to the database should in principle look just like the price feed we used before.

Since there was no data for a long time until this morning, there is also no need to clean up data for correctness.