cowprotocol / token-lists

https://files.cow.fi/tokens/CowSwap.json
Apache License 2.0
3 stars 13 forks source link

Add just some simple way to filter out tokens #398

Closed anxolin closed 1 month ago

anxolin commented 1 month ago

For Arbitrum launch we have one issue, most of the bridged tokens don't have liquidity.

This creates a bad user experience.

This PR allows the script generators to provide a filtering function that will have the last call on which token should be included and which don't.

In this simplistic implementation, I just allow to cherry-pick a bunch of tokens by token symbol. I know..., token symbols are not unique, but this comes from know lists so its not expected to have duplicates, and the configuration feels simpler to read if I can select the tokens to include by token symbol

Important

This PR should not be merged, and the token selection is not final. Chen is deciding on the final list of tokens to include, tomorrow he will provide them, so we can launch with a filtered list.

Edit 04/06/2024

I did a bunch of enhancements for the launch. Some of them need to be iterated later.

The goal was to reduce the list to a bunch of meaningful tokens (chen provided the list)

The problem, some of these were not in our list Another problem was that these tokens provided by chen in a CSV didn't have a lot of the information (token name, decimals, etc)

This PR added:

socket-security[bot] commented 1 month ago

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/csv-parser@3.0.0 None 0 27.7 kB trysound

View full report↗︎