cowprotocol / watch-tower

Conducting the music of Composable CoWs 🎶🐮
GNU General Public License v3.0
7 stars 2 forks source link

test: unit coverage for poll legacy #97

Open mfw78 opened 1 year ago

mfw78 commented 1 year ago

Background

It's frustrating working on the polling legacy logic as it is detailed and lacks unit testing, inhibiting robustness / trustworthiness.

Details

Implement a test harness for unit testing the legacy polling logic. This should be accomplished using jest test harnesses with mock for the getTradeableOrderWithSignature, and unit testing for customErrorDecode.

Acceptance criteria

anxolin commented 1 year ago

I wonder if we should just do this directly in the SDK as part of creating the GenericConditionalOrder