search

cowsay-org / cowsay

apjanke's fork of the classic cowsay project
http://cowsay.diamonds
GNU General Public License v3.0
73 stars 15 forks source link

`make uninstall` does not uninstall all cow files #19

Closed apjanke closed 4 weeks ago

apjanke commented 2 years ago

After doing a make install, make uninstall sequence, I still have cowfile data files left under /usr/local/share.

janke@clooney cowsay % find /usr/local | grep cow
/usr/local/share/cowsay
/usr/local/share/cowsay/cows
/usr/local/share/cowsay/cows/satanic.cow
/usr/local/share/cowsay/cows/telebears.cow
/usr/local/share/cowsay/cows/sodomized.cow
/usr/local/share/cowsay/cows/bud-frogs.cow
/usr/local/share/cowsay/cows/cheese.cow
/usr/local/share/cowsay/cows/kitty.cow
/usr/local/share/cowsay/cows/stimpy.cow
/usr/local/share/cowsay/cows/mutilated.cow
/usr/local/share/cowsay/cows/three-eyes.cow
/usr/local/share/cowsay/cows/kiss.cow
/usr/local/share/cowsay/cows/tux.cow
/usr/local/share/cowsay/cows/dragon-and-cow.cow
/usr/local/share/cowsay/cows/udder.cow
/usr/local/share/cowsay/cows/meow.cow
/usr/local/share/cowsay/cows/www.cow
/usr/local/share/cowsay/cows/hellokitty.cow
/usr/local/share/cowsay/cows/Stegosaurus.pm
/usr/local/share/cowsay/cows/skeleton.cow
/usr/local/share/cowsay/cows/moose.cow
/usr/local/share/cowsay/cows/TextBalloon.pm
/usr/local/share/cowsay/cows/eyes.cow
/usr/local/share/cowsay/cows/bong.cow
/usr/local/share/cowsay/cows/fox.cow
/usr/local/share/cowsay/cows/llama.cow
/usr/local/share/cowsay/cows/koala.cow
/usr/local/share/cowsay/cows/cower.cow
/usr/local/share/cowsay/cows/default.cow
/usr/local/share/cowsay/cows/supermilker.cow
/usr/local/share/cowsay/cows/surgery.cow
/usr/local/share/cowsay/cows/small.cow
/usr/local/share/cowsay/cows/head-in.cow
/usr/local/share/cowsay/cows/Example.pm
/usr/local/share/cowsay/cows/vader.cow
/usr/local/share/cowsay/cows/turtle.cow
/usr/local/share/cowsay/cows/ren.cow
/usr/local/share/cowsay/cows/DragonAndCow.pm
/usr/local/share/cowsay/cows/ghostbusters.cow
/usr/local/share/cowsay/cows/stegosaurus.cow
/usr/local/share/cowsay/cows/elephant.cow
/usr/local/share/cowsay/cows/vader-koala.cow
/usr/local/share/cowsay/cows/daemon.cow
/usr/local/share/cowsay/cows/TuxStab.pm
/usr/local/share/cowsay/cows/MechAndCow.pm
/usr/local/share/cowsay/cows/turkey.cow
/usr/local/share/cowsay/cows/kosh.cow
/usr/local/share/cowsay/cows/sheep.cow
/usr/local/share/cowsay/cows/dragon.cow
/usr/local/share/cowsay/cows/bunny.cow
/usr/local/share/cowsay/cows/mech-and-cow
/usr/local/share/cowsay/cows/Frogs.pm
/usr/local/share/cowsay/cows/blowfish.cow
/usr/local/share/cowsay/cows/elephant-in-snake.cow
/usr/local/share/cowsay/cows/milk.cow
/usr/local/share/cowsay/cows/flaming-sheep.cow
/usr/local/share/cowsay/cows/beavis.zen.cow
/usr/local/share/cowsay/cows/luke-koala.cow
/usr/local/share/cowsay/cows/moofasa.cow
/usr/local/share/cowsay/site-cows
janke@clooney cowsay %

I think that uninstall should delete all of the default cows, leave user-installed cows, and remove any cowsay-installed directories which are now empty. Would probably be nice to detect user modifications to individual cowsay-installed files, and maybe leave those in place.

ndim commented 2 years ago

Just a note: PR https://github.com/cowsay-org/cowsay/pull/26 should fix this issue #19.

apjanke commented 1 month ago

Bumped this to 3.9.0, so I can do a smaller 3.8.0 release with a couple new cows and Asciidoctor fixes.

apjanke commented 4 weeks ago

Looks like PR #26 did fix this. I get clean uninstallations now, with no leftover cows, and the whole share/cowsay dir hierarchy is removed if no extraneous files were added after installation.

Closing as fixed. Will probably go out in 3.8.3.

ndim commented 3 weeks ago

JFTR, I have working CI code checking that make uninstall actually removes everything make install installs.

That will be in an PR soon.