search

cowsay-org / cowsay

apjanke's fork of the classic cowsay project
http://cowsay.diamonds
GNU General Public License v3.0
73 stars 15 forks source link

Revert cowthink.1 to point to cowsay.1 in the same dir #25

Closed ndim closed 2 years ago

ndim commented 2 years ago

For a source tree from git or tarball, if the cowthink.1 file in the source tree is .so cowsay.1, running man ./cowthink.1 will open the cowsay.1 file from the source tree, which is OK.

HOWEVER, if the cowthink.1 file in the source tree is .so man1/cowsay.1, running man ./cowthink.1 will either show the wrong man page from /usr/share/man/man1/cowsay.1 (or elsewhere in MANPATH, I presume), or if no cowsay.1 file is found in MANPATH, will show an empty page.

That is clearly wrong, so reverting to the old cowthink.1 file which points man to the cowsay.1 file in the same directory is clearly better.

This is a new PR as I cannot reopen the PR https://github.com/cowsay-org/cowsay/pull/24 in which I introduced the problem this PR fixes.

apjanke commented 2 years ago

LOL, I guess I should have waited for you to answer my question on the last PR before merging it.

I don't actually understand what's going on here, it would take me a bit of reading & research to get up to speed, but since you made the "bad" change in the first place and this is just restoring old behavior, I'm going to assume you know what you're doing here and just merge it.

Thanks for the contributions and followup here!

ndim commented 2 years ago

LOL, I guess I should have waited for you to answer my question on the last PR before merging it.

You can trust your intuition. You clearly were on to something when you asked that question.

I don't actually understand what's going on here, it would take me a bit of reading & research to get up to speed, but since you made the "bad" change in the first place and this is just restoring old behavior, I'm going to assume you know what you're doing here and just merge it.