search

cowsay-org / cowsay

apjanke's fork of the classic cowsay project
http://cowsay.diamonds
GNU General Public License v3.0
73 stars 15 forks source link

Fix /usr installs #40

Closed apjanke closed 4 weeks ago

apjanke commented 1 year ago

So, it looks like installing to the system /usr prefix is broken. In that case, cowsay does not properly look up its config files in /etc instead of /usr/etc, and there may be other issues.

Didn't notice this because I've been focused on things like "how can cowsay support independent 'system', 'site', and 'user" level definitions of cowfiles and $COWPATHs", and I mostly use Mac Homebrew/MacPorts or on Linux just do a "local" install to /usr/local, so kinda overlooked this glaring basic problem. Bit of egg on my face here.

An Arch Linux developer reported this today (2023-05-20) when they were trying to do a system build & install of cowsay on Arch.

Commentary from the Arch dev:

https://src.fedoraproject.org/rpms/cowsay/tree/rawhide

https://gitweb.gentoo.org/repo/gentoo.git/tree/games-misc/cowsay/files/cowsay-3.7.0-mech-and-cow.patch

https://gitweb.gentoo.org/repo/gentoo.git/tree/games-misc/cowsay/files/cowsay-3.7.0-head-in.patch

The cowthink man page in the current release is pretty useless, but I see some relevant-looking commits on github that might've fixed it.

I also noticed the cowsay manpage uses a literal "%PREFIX%" instead of honoring the one I specified when running make install:

FILES %PREFIX%/share/cowsay/cows holds a sample set of cowfiles.

That'd be better if it just respected what prefix was defined as.

https://gitweb.gentoo.org/repo/gentoo.git/tree/games-misc/cowsay/cowsay-3.7.0.ebuild

Gentoo is doing a sed line to fix all but the last one.

Make /usr installs work good.

apjanke commented 4 weeks ago

See also: https://github.com/cowsay-org/cowsay/issues/49, with a user report of something that looks like this in the wild from a pacman installation.

apjanke commented 4 weeks ago

I think this got fixed with https://github.com/cowsay-org/cowsay/issues/55 and https://github.com/cowsay-org/cowsay/commit/570be8de68bac34356c1aaecdac38a11b007a375. Should go out in 3.8.3.

Closing as Fixed.