cowsay-org / cowsay

apjanke's fork of the classic cowsay project
http://cowsay.diamonds
GNU General Public License v3.0
83 stars 15 forks source link

Remove *.pm format stuff until it's working #54

Closed apjanke closed 2 months ago

apjanke commented 2 months ago

The *.pm (Acme::Cow) Perl module based cowfile format never got fully implemented, and it's not working. But there are still things for it in the code and installations:

Packagers like Debian and I think Arch are patching the installation to get rid of them, for a better user experience.

package() {
 cd ${pkgname}
 make DESTDIR="${pkgdir}" install prefix=/usr
 # missing Acme::Cow module
 rm "${pkgdir}"/usr/share/cowsay/cows/*.pm
}

Let's remove them, so they're not part of the default installation, and the in-repo dev behavior more closely reflects what users will see in an installed cowsay.

I think the special "*.pm format cows are not implemented yet" message when you try to invoke a .pm-format cow is fine to keep.

apjanke commented 2 months ago

Did this in https://github.com/cowsay-org/cowsay/commit/b4d25447a34832607cff23763cf5a1bf1a7160d7. Should go out in 3.8.3.

Closing as Fixed.