search

coyote-team / coyote-drupal

0 stars 0 forks source link

1 implement batch processing of nodes #20

Closed catorghans closed 1 year ago

catorghans commented 1 year ago

Batch processing pull request.

jkva commented 1 year ago

I'm trying to test the functionality, but get an error while running on localhost. Could that be related?

Error: Call to a member function claimItem() on null in /var/www/html/web/core/includes/batch.inc on line 285 #0 /var/www/html/web/core/includes/batch.inc(137): _batch_process()\n#1 [...]

and

Error: Call to a member function getAllItems() on null in /var/www/html/web/core/includes/batch.inc on line 455 #0 /var/www/html/web/core/includes/batch.inc(98): _batch_finished()\n#1 /var/www/html/web/core/modules/system/src/Controller/BatchController.php(55): _batch_page() [...]

catorghans commented 1 year ago

Probably related. So how does your localhost site look? Do you only have nodes without images? Or no nodes at all? (am trying to figure out what the null could be)

jkva commented 1 year ago

Probably related. So how does your localhost site look? Do you only have nodes without images? Or no nodes at all? (am trying to figure out what the null could be)

This is a fresh install, so likely the case of no nodes existing. Is that easy to guard against?

catorghans commented 1 year ago

Probably related. So how does your localhost site look? Do you only have nodes without images? Or no nodes at all? (am trying to figure out what the null could be)

This is a fresh install, so likely the case of no nodes existing. Is that easy to guard against?

No nodes at all! Ok, had not tested that. I can confirm the issue. Solution will follow.

catorghans commented 1 year ago

Probably related. So how does your localhost site look? Do you only have nodes without images? Or no nodes at all? (am trying to figure out what the null could be)

This is a fresh install, so likely the case of no nodes existing. Is that easy to guard against?

No nodes at all! Ok, had not tested that. I can confirm the issue. Solution will follow.

Try again with latest commit

jkva commented 1 year ago

That fixed it 👍