No typings in 1.0.1 npm release

cozmo / jsQR

A pure javascript QR code reading library. This library takes in raw images and will locate, extract and parse any QR code found within.

https://cozmo.github.io/jsQR/

Apache License 2.0

3.72k stars 607 forks source link

No typings in 1.0.1 npm release #45

Closed adriengibrat closed 6 years ago

adriengibrat commented 6 years ago

Hi, Thanks for the good work on jsQR 1.x, The API is now clear and simple ;)

I'm using jsQR 1.0.1 in a typescript project and don't get why the jsqr 1.0.1 npm package does not contains the typings.

Could you publish a 1.0.2 with the typings included (and may be deprecate the 1.0.1 with a message inviting to upgrade to get typings), something like:

npm version patch -m "Upgrade to %s to include typings"
npm publish
npm deprecate jsqr@1.0.1 "Upgrade to >1.0.1 get typings"
git push
git push --tags

thanks ;)

cozmo commented 6 years ago

wtf this is very odd. I want to investigate for a second to make sure there's not a systemic issue in the publishing setup, but then will publish and deprecate. Thanks for the report.

cozmo commented 6 years ago

Hmm, so it would appear that types are also not present in v1.0.0 which is at least good in that it means there wasn't some one off oddity with 1.0.1 but still need to figure out why it's happening.

adriengibrat commented 6 years ago

The .npmignore seems OK to me but:

you could remove the * and add an actual black list
you could also try to add a files entry in package.json

To check what will be published, run npm pack

cozmo commented 6 years ago

Just published v1.0.2 which has the types. #46 has the details of the bug if you're curious. Thanks for the report, sorry about the issue.

adriengibrat commented 6 years ago

:+1: