search

cozmo / jsQR

A pure javascript QR code reading library. This library takes in raw images and will locate, extract and parse any QR code found within.
https://cozmo.github.io/jsQR/
Apache License 2.0
3.7k stars 607 forks source link

Features/support structured append #98

Open vertical-axis opened 6 years ago

vertical-axis commented 6 years ago

Dear @cozmo jsQR has not supported "Structured Append QR Code" yet. I implemented code about it. Could you check my code and accept my pull request?

cho45 commented 5 years ago

+1

kousu commented 5 years ago

I just noticed this after I implemented it from scratch myself in #132. Sorry @vertical-axis! It seems like the core of our patches are identical, but I'm going to leave mine open becaue it seems like yours has fallen behind the master branch.

We could merge our tests together: you wrote a unit test, I wrote an end-to-end test that uses structured append to reassemble fragments. I think they're both helpful :)