bug: `ReorderSort` does not work as expected

[creatorrr]

ReorderSort does not return anything. Am I doing something wrong? @zh217

Query:

test[a] <- [[1], [2], [3]]

?[i, x] <~ ReorderSort(test[a], out: [a], sort_by: [-a])

Expected:	i	x
1	3
2	2
3	1

Actual:	i	x

[wti]

Working for me with take: n != 0 e.g.,

test[a] <- [[1], [2], [3]]

?[i, x] <~ ReorderSort(test[a], out: [a], sort_by: [-a], take: 10)

So it looks like the default value for take of 0 does not have the documented magic significance of unbounded.

[wti]

See https://github.com/cozodb/cozo/blob/6ab063c627a57242ff42d563dfa1ce41264bcc72/cozo-core/src/fixed_rule/utilities/reorder_sort.rs#L112

perhaps:

if 0 != count && count > take_plus_skip {
    break;
}

[wti]

Proposed fix in PR https://github.com/cozodb/cozo/pull/277

[creatorrr]

Ah that makes sense! Thanks for the catch and the fix 😄 Closing