Disabling Gamechat doesn't show player color to libs in private and blind games

cozuya / secret-hitler

A web adaptation of the social deduction board game Secret Hitler. https://secrethitler.io

Other

840 stars 201 forks source link

Disabling Gamechat doesn't show player color to libs in private and blind games #1401

Open Vigasaurus opened 5 years ago

Vigasaurus commented 5 years ago

Describe the bug Games with Gamechat disabled, and if Private or Blind don't show liberals their player color, and it shows all players as white. Fascists all see the correct colors.

What does this issue relate to? Please put an X in the [ ] (i.e. turn [ ] into [X]) for the relevant choice.

[ ] Gameplay
[X] User Interface
[ ] Game Modes
[ ] Mod Tools
[ ] Replays
[ ] Something Else: Please describe

thepenguinco commented 4 years ago

I can take a look at this.

iounpaladin commented 4 years ago

Is https://github.com/cozuya/secret-hitler/blob/master/src/frontend-scripts/components/section-main/Players.jsx#L276-L278 the cause of this?

stevenruidigao commented 4 years ago

Yeah I think

Vigasaurus commented 4 years ago

No, it shouldn't be. PLAYERCOLORS() doesn't care about game states, it's purely for rank, and elo colors.