change binding from j/k to left/right arrow keys

denisecheung3 commented 3 years ago

Changes

maintain hjkl replay keys, add left/right and shift + left/right controls

Screenshots

not very useful but tested locally

Below you'll find a checklist. For each item on the list, check one option (if completed) and delete the other as appropriate. (Delete this line too)

Tested Locally

[X] This PR has been tested locally, and ensured to not cause any breaking changes
[X] This PR makes a trivial change

Tests

[] Automated tests have been added
[X] This PR does not require tests

Changelog

[X] Changelog Section below has been updated with Changelog entry
[ ] This PR does not make a user-facing change

Changelog Entry (delete this section if this PR does not need a changelog entry)

Check one, delete the other:

[X] New Feature - not really a new feature but an enhancement for more intuitive replay controls

Check one, delete the other:

[X] Minor Change

Changelog Headline: maintain hjkl replay keys, add left/right and shift + left/right controls

Changelog Details: replay controls will now be: Use j/k or left/right arrow keys on replay to go backward/forward one tick Use h/l or shift + left/right arrow keys on replay to go backward/forward one gov

Vigasaurus commented 3 years ago

Nice, thanks! To be clear, that issue isn't super detailed, but it would also include changing the forward/back an entire gov to be Ctrl+Arrow or Shift+Arrow instead of the h/l it is now.

denisecheung3 commented 3 years ago

Nice, thanks! To be clear, that issue isn't super detailed, but it would also include changing the forward/back an entire gov to be Ctrl+Arrow or Shift+Arrow instead of the h/l it is now.

Ok that makes alot of sense, will try to work on it ASAP

Vigasaurus commented 3 years ago

Also, there was an addendum request there to maintain the hjkl keybinds, and just tack the arrow keys on top.

Vigasaurus commented 3 years ago

Awesome, thanks!

cozuya / secret-hitler