search

cozuya / secret-hitler

A web adaptation of the social deduction board game Secret Hitler. https://secrethitler.io
Other
840 stars 202 forks source link

File splitting 2 #1914

Closed iounpaladin closed 3 years ago

iounpaladin commented 3 years ago

File Splitting -- tested everything locally (every part of u-e as well as fixes from commands) but I'd still appreciate review. This also includes https://github.com/cozuya/secret-hitler/pull/1913 rebased on top so if you merge this that can be closed. I'm still investigating the other bug and will likely push on top, I just wanted to submit this.

cozuya commented 3 years ago

what in the world is going on here?

iounpaladin commented 3 years ago

um, splitting the 4,000 line user-events file into multiple smaller files? or the messy commit history

cozuya commented 3 years ago

oh lol totally misread this. no this is great, I tried to do this a while ago with moderation but didn't get it in, will look later, thanks!

iounpaladin commented 3 years ago

ah, perfect, thank you! i'm also looking into the crash from earlier which will be a PR based on this since it'll almost certainly conflict