search

cozuya / secret-hitler

A web adaptation of the social deduction board game Secret Hitler. https://secrethitler.io
Other
814 stars 203 forks source link

Wrong number of players displayed in game room #1924

Closed Sakuya-Izayoi closed 2 years ago

Sakuya-Izayoi commented 2 years ago

Describe the bug

When creating a game, say, for 7 players non-rebalanced the number of players required in game room seems random. For example, on screenshot, I have created non-rebalanced 7p game (with checkbox checked only on non-rebalanced 7p games), but the number in game room says R9, meaning rebalanced 9p games. Although, the game's still waiting for 7 players to join.

Category

User Interface

What browsers are you seeing the problem on?

Chrome

Relevant log output

No response

Extra context

iounpaladin commented 2 years ago

I don't think this is a bug, you can set R9 or any rebalance independently of the allowed player counts. So, for example, you could have R6 set for a 7-9 player game, which would have no effect.

Sakuya-Izayoi commented 2 years ago

The point is, i didn't set R9. I only have checked normal 7p games checkbox, any other are unchecked.

iounpaladin commented 2 years ago

Ah I see, I'll look into it, thanks

Vigasaurus commented 2 years ago

Fixed in #1926