cozuya / secret-hitler

A web adaptation of the social deduction board game Secret Hitler. https://secrethitler.io
Other
814 stars 203 forks source link

Blanket Ban List Mod Tool #1935

Closed sadnixon closed 2 years ago

sadnixon commented 2 years ago

Changes

Adds a new mod tool which allows accounts belonging to Blanket Banned players to be tracked. It allows a CSV spreadsheet to be downloaded which gives their current obfuscated IPs.

Screenshots

I'm not sure if I should add screenshots of the mod tools but I can provide them if you need them!


Tested Locally

Tests

Changelog

iounpaladin commented 2 years ago

Thanks for this! I'll review it when I have the chance, unfortunately maybe 1 day or so -- edit: Vig is reviewing first

Vigasaurus commented 2 years ago

Yeah I think we need to discuss this implementation a lot more (which is partially why I never really did a formal review here). I know we talked (privately) about potentially doing this as an interim solution, but on second thought, I really don't like the concept of making these sort of extra reports to be used more manually - I'd much rather a system like this just be integrated into wherever it'd get used (which was the final stage of this as we had discussed anyways) from the initial version of said feature - theoretically similar to the IP highlighting in the mod panel, but on signups or wherever else (this'd be up to y'all as needed). I'm gonna close this for now, and we can discuss further back on Discord as to where this feature should end up in its final stage/best version of it and work towards getting it there.