cozuya / secret-hitler

A web adaptation of the social deduction board game Secret Hitler. https://secrethitler.io
Other
841 stars 202 forks source link

Update Playerlist.jsx #1938

Closed stevenruidigao closed 2 years ago

stevenruidigao commented 2 years ago

Changes

Please describe the changes made in the pull request here.

Tell Google Translate to stop translating names.

Screenshots

These are effectively required for non-trivial changes, but appreciated for all.


Below you'll find a checklist. For each item on the list, check one option (if completed) and delete the other as appropriate. (Delete this line too)

Tested Locally

Tests

Changelog

Changelog Entry (delete this section if this PR does not need a changelog entry)

Check one, delete the other:

Check one, delete the other:

Changelog Headline: Google Translate

Changelog Details: Use Google Translate. See if site breaks.

Vigasaurus commented 2 years ago

I'm confused - can you give some more detail on what exactly the issue was/what this solves (and maybe a more relevant changelog message 🙈 )? I may just be missing it, but does this resolve the Google Translate related UI crashes we had? Or is it just the nice to have don't-translate for usernames?

stevenruidigao commented 2 years ago

I'm confused - can you give some more detail on what exactly the issue was/what this solves (and maybe a more relevant changelog message 🙈 )? I may just be missing it, but does this resolve the Google Translate related UI crashes we had? Or is it just the nice to have don't-translate for usernames?

Yup. Should fix the Google Translate UI problems, but I can't be sure because it seems to happen only some of the time (also, names shouldn't get translated anyways).

Changelog Message: Don't translate usernames.