Avalon SH (WIP)

[themeeman]

Adds two new modes to the game.

• Avalon SH, which adds the merlin role to the game, who is a liberal who knows who all of the fascists are. If the game is a liberal win, then the game goes to the assassination phase, where hitler's role card is revealed, their regs are revealed to them, and they can can guess who merlin is. If they guess correctly, fascists win the game. Optionally you can add percival and morgana as well, percival being a liberal who sees who merlin and morgana, a fascist, are, but does not know which is which.
• Each of these new roles has a custom role card, designed by jules (not done).
• Also adds the new /gm command as an extension to line guessing, where observers can guess who merlin is in Avalon SH games.
• This also changes the /forceskip command to automatically assassinate if hitler is AFK.
• No topdecking, where topdecking results in a fascist win, like the hammer in Avalon. Alternatively, there is also no double topdecking where you can TD once but not twice consecutively.

Both of these modes have full replay support.

[iounpaladin]

Let me know once this is done and I'll review it.

[iounpaladin]

I'm so sorry it took me this long to get to this. It's a large PR and I was pretty busy, but it's finally reviewed. This looks amazing, thank you SO MUCH for putting in the effort to make this, it's incredible. I stress tested everything and apart from my notes everything works perfectly. I have a couple small notes (I initially thought there was a large-scale issue but I realised that it was an issue with my local setup, this also contributed to the time it took to review this):

• Selecting Avalon SH says "Casual only" so it should change the game mode to casual in the game creation UI (it's properly set server side when the game is actually created) -- same for no TD
• When starting a game with Morgana and receiving the Morgana role, I got the following text: This game has merlin, percival and morgana. The game begins and you receive the morgana role and take seat #4. You see that hitler in this game is ddd {5}. They also see that you are a fascist.

Should the hitler/fascist text be changed to match as well? Or is it meant to stay the same because of the Hitler election still existing?

• Assassination wins are improperly reported as losses on the fascists' profile (as are heils)

These are pretty small issues and I can absolutely take care of them myself if you are busy (you already did so much for this and it is greatly appreciated). Just let me know.

[themeeman]

Thanks for looking :)

  The game begins and you receive the morgana role and take seat 4.
  You see that hitler in this game is ddd {5}. They also see that you are a fascist.

Should the hitler/fascist text be changed to match as well? Or is it meant to stay the same because of the Hitler election still existing?

No I don't think these should be changed, since morgana is still a member of the fascist team, so to say they are "a fascist" would be correct. Hitler is unaffected by this so it should remain the same. Also, hitler wouldn't know which regular fascist is morgana, so saying "they also see you are morgana" would be incorrect.

These are pretty small issues and I can absolutely take care of them myself if you are busy (you already did so much for this and it is greatly appreciated). Just let me know.

Yeah that would be great if you could do them, I can't see it taking long anyway. Thanks.

[iounpaladin]

Perfect, that makes sense. I'll ideally get it done by the end of the week and have it merged by then as well. Thank you again :D