search

cozuya / secret-hitler

A web adaptation of the social deduction board game Secret Hitler. https://secrethitler.io
Other
837 stars 202 forks source link

Profile.jsx & more improvements (Swal, jQuery, blacklist UI, bug fix) #1961

Closed samfuller01 closed 2 years ago

samfuller01 commented 2 years ago

Changes

Overhauled the blacklist modal, removed jquery, made it into a react-sweetalert2 modal, removed some unused or unneeded code, updates existing sweet alert modals in profile.jsx, and fixes issue with AEM not seeing the delete button on their blacklists in the Profile.jsx file. Switched all Swal modals to react-sweetalert2 modals.

Screenshots

image

Tested Locally

Tests

Changelog

Not applicable -- lumped into past blacklist UI changes.

Check one, delete the other:

Check one, delete the other:

iounpaladin commented 2 years ago

I looked at the code and this looks good, I don't like that this is necessary but unfortunately it is and I like the implementation. I'll do a full test when I have the time but the code looks good.

iounpaladin commented 2 years ago

Seems to work based on my testing, thanks! Only request is that the popup for the blacklist be styled according to the user style. Thanks for this!