Blacklist UI overhaul - Githubissues

cozuya / secret-hitler

A web adaptation of the social deduction board game Secret Hitler. https://secrethitler.io

Other

840 stars 202 forks source link

Blacklist UI overhaul #1965

Closed samfuller01 closed 2 years ago

samfuller01 commented 2 years ago

Changes

Revert react-sweetalert2 and update blacklist modal.

Screenshots

Tested Locally

[X] This PR has been tested locally, and ensured to not cause any breaking changes

Tests

[X] This PR does not require tests

Changelog

[X] Changelog Section below has been updated with Changelog entry

Changelog Entry (delete this section if this PR does not need a changelog entry)

Check one, delete the other:

[X] Bug Fix

Check one, delete the other:

[X] Minor Change

Changelog Headline: Update Blacklist Modal UI

Changelog Details: Replaces the old blacklist ui with a new table

iounpaladin commented 2 years ago

I was finally able to test this and it looks excellent. Only issue I can find is that clicking player's usernames from the blacklist modal consistently gives me the insertBefore error but that may not be correlated. Honestly, you could probably just remove the link since the insertBefore has been an issue forever and it hasn't been fixed. You could also try to fix the issue but that's not necessary. If you wouldn't mind just removing the link that would be great and I'll merge. Thank you for this!