search

cozuya / secret-hitler

A web adaptation of the social deduction board game Secret Hitler. https://secrethitler.io
Other
837 stars 202 forks source link

Monarchist SH #1989

Open Shrauger opened 6 months ago

Shrauger commented 6 months ago

Changes

Please describe the changes made in the pull request here.

Adds a button in lobby creation for the Monarchist gamemode. Doesn’t permit ranked games if turned on. Replaces a fascist with a monarchist (who has colors, art, fasc alignment on invest, etc,.) Allows for the monarchist to shoot Hitler despite being fascist aligned Changes it so Hitler’s name turns to red whenever investigated by anything other than a regular fascist Sends chat messages based on Monarchist being in the game. Changes profile data to be recorded as a loss for the monarchist depending on game ending type as opposed to just fasc or lib win.

Screenshots

image Base 5p game. image Working with AvaSH image Invest working on Hitler for the Monarchist Card art image

image image image In-game text. Not shown here, but Monarchist can in fact shoot Hitler by default. These are effectively required for non-trivial changes, but appreciated for all.

Below you'll find a checklist. For each item on the list, check one option (if completed) and delete the other as appropriate. (Delete this line too)

Tested Locally

Tests

Changelog

Changelog Entry (delete this section if this PR does not need a changelog entry)

Check one, delete the other:

Check one, delete the other:

Changelog Headline: Added new custom fascist role game mode.

Changelog Details: Added monarchist as a playable game mode. This is a negative utility fascist who only wins on six reds and executing Hitler. They see regular fascists but not Hitler and appear as a fascist on investigation.

iounpaladin commented 6 months ago

Who made the art for the card? (Just want to confirm it doesn't violate licensing).

I'm not a maintainer anymore so I can't approve the checks or review it :)

Shrauger commented 6 months ago

I made the art.

Shrauger commented 6 months ago

Honestly other than the minor spacing issues this looks fine from a surface look no real notes. @Vigasaurus any thoughts here at your convenience would help thanks

Looks like there's an issue with profile replays still. Thought I set it up properly but as Paladin pointed it out on Discord its not the appropriate setup. Spent the last 2-3 hours testing gameplay and realized that monarchistSH + avalonSH have an issue if there is only 5-6 players (which was preventing percival from having 2 merlin candidates.)

Edit: fixed the 5-6 ava-mona issue!