cozuya / secret-hitler

A web adaptation of the social deduction board game Secret Hitler. https://secrethitler.io
Other
840 stars 201 forks source link

Request Emotes #207

Open andy013 opened 6 years ago

andy013 commented 6 years ago

Want an emote for the site but don't see it in this list?

request one in the comments and if it gets enough support we would love to add it! (assuming it is not nsfw...)

NukertSH commented 6 years ago

hehe, i like it

DennisTheFinn commented 6 years ago

so like the emotes we currently have on our discord? https://discord.gg/wCfXkMd

-- I don't however like the idea of getting rid of claims panel... but it could be updated to include the card emotes...

DennisTheFinn commented 6 years ago

I think this would be a great benefit that you would have to earn, where you cant access the emoji's right away, you have to get rainbow or something

andy013 commented 6 years ago

I worked on a bunch more and cleaned up the ones from before so they look better on a dark grey background.

Check em out: JaCard = NeinCard = FasSkull = FasSkull2 = LibBird = LibBird2= Ja = Nein =

Not sure which version of the policies is best, I think I like the first lot with the large letters: FasPolicy =
LibPolicy = FasPolicy2 = LibPolicy2= FasPolicy3 = LibPolicy3 =

Hitler = Fas2 = Fas0 = Fas0_2 = FasGrin = FasGrin2 = Lib3 = Lib3_2 = RedFace = LibStare = LibStare2 = Lib5Zoom = Lib5 = LibSmile = SillyLib = BangBang = Skull = NotHilter = TopDeck = PDraw3 = PBullet = PInvest = PPres = FasGlory = LibGlory = FasGoofy = FasFrog = FasCroc =

I thought it would be fun if you could add twitch.tv style emotes to the chat. If you're not familiar they are small 28x28 images that are displayed in place of a unique case sensitive string.

For example: CardNein = VoteNein CardJa = CardYa VoteJa = VoteYa VoteNein = VoteNein LogoFas = LogoFas LogoLib = LogoLib FasSkull = FasSkull LibBird = LibBird RoleLib = RoleLib RoleFas =RoleFas SecretHilter = SecretHitler

I'm not very good with photoshop but I just quickly resized these images to see what they would look like and I think it would be a cool little feature to add. Perhaps you could add some for the cards as well and then get rid of the claims panel and just use emotes instead. That way people can reclaim later if that is part of their strategy. You could also have unique emotes that you can unlock by playing a certain number of games or winning tournaments etc. Also having tab auto complete for the strings would be very convenient.

DennisTheFinn commented 6 years ago

it says 'not hilter'

andy013 commented 6 years ago

Oops, I changed it in photoshop but forgot to export before uploading.

Here's an alternative as well:

I also did these extra ones

heyLibs = heyFas =

DennisTheFinn commented 6 years ago

wanna make a veto one?

andy013 commented 6 years ago

andy013 commented 6 years ago

Hey, so I decided to have a go at implementing this. I put a branch up here if you want to check it out: https://github.com/andy013/secret-hitler/tree/emotes

It works fine, but since I'm very inexperienced with javascript I'm not sure if my implementation is the correct way to do it. I didn't know how to prevent the image links being escaped so I just used react to render the image tags. The only issue I had was the console keeps throwing up an error about them not having unique keys. Since they are emotes that will be reused I don't think it's possible to give them a unique key.

There's probably a much simpler way of doing it but I couldn't figure it out yet.

cozuya commented 6 years ago

Cool I can take a look (and the key thing is an easy thing to get around) but could you actually make a PR to this repo instead? Its a pain installing this thing :p

andy013 commented 6 years ago

Oh yeah, sure. I didn't know if it was appropriate to do a PR for something like this (that I'm not sure will be included in the main branch).

cozuya commented 6 years ago

Nah if we don't wind up using it no problem with it being here and closed.

DennisTheFinn commented 6 years ago

hey @andy013 no pressure but I would love to have more emotes! lmk what you think!

DennisTheFinn commented 6 years ago

we need a CNH one!!!

coolanybody commented 6 years ago

I don't know how to make images but I'd personally love a thinking emote for all the stuff that really makes you think 🤔

cozuya commented 6 years ago

I like it but not sure about licensing. @DennisTheFinn if you want to make one (and a cnh one) I could get it in. or uh find an open source version.

Cayseron commented 6 years ago

👍 ThumbsUp 🍿 PopCorn and a CNH emoji......

cozuya commented 6 years ago

I can get that in

Ophxlia commented 6 years ago

a red loveheart!

ghost commented 6 years ago

Hey @peeps, I feel like I want to be on an emoji input stream for the site. Let me know if u have any ideas u want to see added and ill get them in pending on master coz's approval of course. All such emojis/emotes must be in compliance with the site and game rules. Feel free to PM me or to ping me any suggestions or images u have that ud like to see become an emote for the general lobby chat and the game chat. I recently made a pizza emoji to accompany what already exists. Hit me up! :smile:

ghost commented 6 years ago

PopCorn and RedHeart and ThinkFace and PIZZA what else? ;) hit me up @LordVader#9988 - Discord https://discord.gg/secrethitlerio

ghost commented 6 years ago

@coolanybody , @Cayseron , and @Ophxlia : I got the ThinkFace, PopCorn, and RedHeart emojis/emotes into the code as soon they are reviewed. by @cozuya .

ghost commented 6 years ago

ExpressionlessFace is implemented @cozuya :D

Max1071 commented 6 years ago

Need salt emote ASAP!

ghost commented 6 years ago

Check! https://github.com/cozuya/secret-hitler/pull/785 ;)

d4s0n commented 6 years ago

libs win!!! and fas win!!!! ple

Lord-Zuko commented 6 years ago

we should have the ThumbsDown emoji as well lul

Max1071 commented 6 years ago

duh HEIL! emote ofc suggested by Buffel

samfuller01 commented 5 years ago

Honestly this doesn't seem to be used anymore. It could probably be closed. The last comment was almost a year ago.

Max1071 commented 5 years ago

I have this issue tied to the Emote page on the wiki. I'd prefer to keep this open.

samfuller01 commented 5 years ago

Ok then we can keep it open @Max1071

Lord-Zuko commented 5 years ago

Would like to suggest the addition of "LibPensive" (https://i.imgur.com/iGVRcB4.png) & "LibThink" (https://i.imgur.com/sya4HFU.png)

Max1071 commented 5 years ago

EpicFlamingHitler

evanmnjd commented 5 years ago

https://imgur.com/uvUJ9Qn

i dont think of it as "sleepy" but more like a sarcastic cry. its art. :)

Vigasaurus commented 5 years ago

Just copying over: #1467

Mistery1307 commented 4 years ago

Alright, it'd be cool to have this emote, ChillOut, for when you get put in the freezer(Being put in the freezer means that you get locked out of elections, and get neined every time, most likely because of unresolved conflicts.) ChillOut

realDerekTan commented 3 years ago

Consider adding these two emojis, the high elo players will love them.

NO RBB WE WON

Vigasaurus commented 3 years ago

Yeah I like them quite a bit, as far as concept and implementation goes. I think they need some work to make them a bit more compacted to look good at 28x28 and maybe some for the rbb to make it more in line with the rest of the theme of the site (see top deck emote). I think the latter is very good, and if compacted should look great. (Both should also be transparentized)

realDerekTan commented 3 years ago

I think there's a way to transparentize both images, but at the size of 28x28, it shouldn't make that much of a difference. I didn't find the font for the TopDeck emote, so I decided to use a good looking font of my own. I think if you scale it down it shouldn't be that big of a problem. Perhaps test it with the sample images here and let me know if it needs further fixes?

Vigasaurus commented 3 years ago

Yeah if you want to transparentized them, and scale them to 28 I can try them out/re-review. As for RBB, I think Germania One could look okay as a font (it's on Google Fonts) - but honestly after looking at yours a bit more, it's not bad.

Lord-Zuko commented 3 years ago

there is, just slap em in paint.net and delet the background. the transparent background is just so if somebody has it set to a different background color it won't show up

Lord-Zuko commented 3 years ago

W/a bit more modification you can make it say "no rrb"

MontyMongo commented 3 years ago

stealing my cardback and using it as an emote >:(

Lord-Zuko commented 3 years ago

bababooey