cozuya / secret-hitler

A web adaptation of the social deduction board game Secret Hitler. https://secrethitler.io
Other
839 stars 202 forks source link

Code Difficulties... Weird refreshing and no card back functions #330

Closed ghost closed 6 years ago

ghost commented 7 years ago

Hey @cozuya , I just re-cloned the github code as it currently stands and there are many great things changing and getting better but 2 big things that I am not sure if you are still working on for the official release for 0.9.0 10/21/2017 or if my localhost:8080 will always do these wrong: Card Backs & Refreshing Problems....

The card back one is simple enough, I am not allowed to upload card backs at all and i also dont even have the default card back it is just a blank black space... Hopefully this is temporarily the way you know you have it but if not... do u know how I can fix my cloning and development processes so that this error disipates?

The refreshing problem seems more complex in actuality and definetely in explanation here. I think what's happening is that I have to refresh for everything to register especially regarding game creation and deletion. In order for the localhost site or perhaps your current code for now from github has it so that when I click leave game, the game itself is still in the lobby with 1 player seated until i refresh the page itself. The Leave Game Button is insufficient. The same for default game button and Uther and Rexar and all the other weird accounts. When I push these buttons (The account quick log in ones nothign happens....) When I do default game or I keep creatign games over and over without refreshing I cannot get rid of the games in the lobby and they all have 1 player seated even though I am the only one online even with refrshing....

I do not want but I also hope that the issues are temporary and known to you in the code currently as stuff u will fix b4 0.9.0 so that when i clone again at that time these issues leave me. But will that be the case? Is it possible my nodejs and mongodb and other stuff is not doing its job right and that why these issues exist? I hope not :(

Lastly, on the CMD side of things not the site or code i think, I have trouble with npm WARN deprecation warnings when I do the npm i -g gulp nodemon commands and the npm i commands from Installation README setup. And I have to always insert new weird code into the node modules>mongodb>lib>url_parser.js file each time I do a new fresh clone of your github code due to a new issue that comes up when i run the nodemon bin/dev command. And for the gulp command I have many weird coding errors pop up that need addressing...

Are any and/or all of these issues descirbed here related to incomplete code on your side of things on github or un-updated node modules and mongodb modules ??? Thanks for help if applicable in this process.

cozuya commented 7 years ago

yeah def don't recommend you work off of master if you're looking to do new stuff, instead checkout the latest stable commit in this case v0.8.2. Sourcetree is a good resource for that if you google it. Master branch until an official release can have breaking changes. In this case leaving game is busted for sure and will be fixed in the next couple days along with deleting games with no one in them.. Also yeah I somehow deleted the default cardback and will restore it. Haven't seen any issues with the mongodb package but will do regression testing before 0.9. To use the "weird" accounts you'll have to create them, they are dev helpers and will auto join a dev game but thats probably busted too. Did not know uploading cardbacks was busted and will take a look at that (are you using a rainbow account?) But yeah should probably put the above in the readme or something, I'll work on that in the next week or so.

cozuya commented 7 years ago

also recommend you keep on eye on roadmap.txt as I'm keeping that updated https://github.com/cozuya/secret-hitler/blob/master/docs/roadmap.txt#L50

ghost commented 7 years ago

ok kool thanks a lot. How do i work with 0.8.2 stable?? where do i find the code for that section?

ghost commented 7 years ago

Also for the extra buttons of default game and all those user log ins, how do i keep those available but make them invisible when i send out my url with localtunnel.me?

cozuya commented 7 years ago

I can't help you with anything other than running this on localhost.

ghost commented 7 years ago

ok. so on localhost those buttona are always visible even though they are not on sh.io??? confusing...

cozuya commented 7 years ago

I take them out manually prior to doing updates.

ghost commented 7 years ago

ok kool

ghost commented 7 years ago

so 0.9 is tomorrow or sunday?