search

cozuya / secret-hitler

A web adaptation of the social deduction board game Secret Hitler. https://secrethitler.io
Other
840 stars 201 forks source link

Webpack: add hot module replacement #724

Open cozuya opened 6 years ago

cozuya commented 6 years ago

This requires webpack dev server or w/e, not sure how to make that work with express backend. No idea why this is a problem in 2018.

ghost commented 6 years ago

@cozuya is this in regards to what used to be gulp build? I tried running yarn build from webpack's readme instructions and it errored out. Does this fix require adding a new file with the needed information or editing a specific existing one?? With the master's readme after your most recent commits today i did run the new commands u had and localhost technically worked. the /game page was fine but the home page of .io is having trouble with design for the header area where the links are for rules, how to play, about, stats, polls, etc. I could see none of those buttons but could still click on them. I assume this fix will make that weird problem go away? Where would I look to start this if i tried to?

cozuya commented 6 years ago

This should help. Its not uncomplicated =/ https://webpack.js.org/concepts/hot-module-replacement/

ghost commented 6 years ago

image

ghost commented 6 years ago

after running yarn build i got these yellow errors.. is this to what u r refering?

image

ghost commented 6 years ago

@cozuya ideas in #735 nowhere near close though on understanding or solving this/implementing it...

ghost commented 6 years ago

So this is maybe the issue relating to css building issues on home page for windows new clones?

Vigasaurus commented 5 years ago

I didn't even know this was an issue 😑

Should be like a 30 second fix (just gonna go copy paste from my other project real quick 😉)

Spyro9955 commented 5 years ago

did u do this?