Closed maboiteaspam closed 10 years ago
Thank you for that big PR! But many changes lead to hesitations :)
Here they are:
I add comments to your code for detailed review.
yes lots of changes. I think api needed to mature. And will need again later.
I'm not sure we should split the main in two files right now. Cozy Light aims to be simple to contribute to. Having a single file for the code is good for that.
yeah maybe. To me it s more clear like this, i can separate error management from what is the library itself. So that if other program would like to take advantage of it, it become possible.
I did not understand really well the problem about the dashboard.
For the screencast...: /
the websocket is a simple server that push a message memoyChanged on an interval, and two other for plugins and apps list when a client connects. Kind of dirty, but works fine.
Still, they are some others fixes, like error management that you could probably include in your version. reset of the port number clear close of the servers restartwatcher
Well i did it becasue i believe it needs.
Ok fix my code remarks. Then, I will merge your PR and see if I remove something after.
here you go, thanks for re read.
to be verified.