search

cozy / cozy-banks

A Banks Aggregator on Cozy
https://cozy.io
GNU Affero General Public License v3.0
59 stars 26 forks source link

fix: Don't crash service if there is no database #2693

Closed Crash-- closed 9 months ago

Crash-- commented 9 months ago

Now, each errors are thrown... So if there is no database because there is no bills for instance, the service was crashing.

So I took this commit https://github.com/cozy/cozy-banks/commit/7a8a8a33ad353a59d88334076d54bcf9cf80be6c and test if the error is because there is no database before throwing.

=> Already reviewed & merged on the beta branch

bundlemon[bot] commented 9 months ago

BundleMon

Files updated (4) Status | Path | Size | Limits :------------: | ------------ | :------------: | :------------: :white_check_mark: | services/onOperationOrBillCreate/banks.js
| 1018.74KB (+237B +0.02%) | - :white_check_mark: | services/budgetAlerts/banks.js
| 982.87KB (+22B 0%) | - :white_check_mark: | services/konnectorAlerts/banks.js
| 1007.31KB (+14B 0%) | - :white_check_mark: | services/recurrence/banks.js
| 1008.57KB (+14B 0%) | -
Unchanged files (40) Status | Path | Size | Limits :------------: | ------------ | :------------: | :------------: :white_check_mark: | screenshots/fr/screenshot4.png
| 1.29MB | - :white_check_mark: | screenshots/en/screenshot4.png
| 1.28MB | - :white_check_mark: | screenshots/fr/screenshot5.png
| 1.17MB | - :white_check_mark: | screenshots/en/screenshot5.png
| 1.17MB | - :white_check_mark: | services/categorization/banks.js
| 1.13MB | - :white_check_mark: | services/autogroups/banks.js
| 446.3KB | - :white_check_mark: | services/linkMyselfToAccounts/banks.js
| 445.76KB | - :white_check_mark: | screenshots/fr/screenshot1.png
| 330.32KB | - :white_check_mark: | screenshots/en/screenshot1.png
| 311.39KB | - :white_check_mark: | screenshots/fr/screenshot2.png
| 264.27KB | - :white_check_mark: | screenshots/en/screenshot2.png
| 256.24KB | - :white_check_mark: | screenshots/fr/screenshot3.png
| 246.98KB | - :white_check_mark: | screenshots/en/screenshot3.png
| 243.76KB | - :white_check_mark: | img/veepee-info.43d778410d97b8e73b4eb07bb4631
d74.png
| 173.24KB | - :white_check_mark: | img/veepee-info@2x.e00642b6164d2b110ebd6a1443
9fcda5.png
| 167.13KB | - :white_check_mark: | img/ameli-side.7173251188c5fe0d8d54e265f8426a
89.png
| 115.29KB | - :white_check_mark: | vendors-banks.(hash).(hash).min.css
| 28.3KB | - :white_check_mark: | img/veepee.9d3db3d18a5534582eba5b9fdbddb8bf.p
ng
| 25.01KB | - :white_check_mark: | img/transfer-error.81739cda73db9309b4f58bf975
ee3856.jpg
| 24.69KB | - :white_check_mark: | img/transfer-done.952c792c91ee5a8b70e025e85bf
4938a.jpg
| 13.95KB | - :white_check_mark: | 83ef4de322a6ddf7034d4b1366d1c9fe.png
| 9.59KB | - :white_check_mark: | icon-banks.jpg
| 8.09KB | - :white_check_mark: | img/search-illu.4536cb0962f2010e397bb96aeed5b
415.svg
| 4.48KB | - :white_check_mark: | img/timeline_desktop_fr.8a2f9796b9d34fdc21eec
489d2f16db1.svg
| 3.94KB | - :white_check_mark: | img/timeline_mobile_fr.e42a3b60dcefcdbae40e44
9c49c01d83.svg
| 3.83KB | - :white_check_mark: | img/timeline_mobile_en.0f4ace6755128e27a825e0
31b0480a71.svg
| 3.66KB | - :white_check_mark: | img/timeline_desktop_en.8ed0e7248216da5fb042e
30314036a39.svg
| 3.51KB | - :white_check_mark: | mesinfos/favicon-32x32.png
| 1.39KB | - :white_check_mark: | mesinfos/favicon.ico
| 1.19KB | - :white_check_mark: | mesinfos/favicon-16x16.png
| 1.11KB | - :white_check_mark: | img/NoAccount.5cd307dbe22ac700d2f570f2c33487e
3.svg
| 1021B | - :white_check_mark: | mesinfos/icon-bank.svg
| 645B | - :white_check_mark: | index.html
| 526B | - :white_check_mark: | img/pie-demo.5d713502666ac766dddccd37e34b0089
.svg
| 449B | - :white_check_mark: | 8751e4271e335d10b8e2d7ca83837d1b.png
| 322B | - :white_check_mark: | bfca87187b6aff074f409395499acc1e.png
| 311B | - :white_check_mark: | favicon-32x32.png
| 242B | - :white_check_mark: | public/safari-pinned-tab.svg
| 229B | - :white_check_mark: | favicon-16x16.png
| 216B | - :white_check_mark: | icon-banks.svg
| 188B | -

Total files change +280B 0%

Groups updated (1) Status | Path | Size | Limits :------------: | ------------ | :------------: | :------------: :white_check_mark: | services/**
| 8.21MB (+459B +0.01%) | -
Unchanged groups (3) Status | Path | Size | Limits :------------: | ------------ | :------------: | :------------: :white_check_mark: | vendors/**
| 1.31MB | - :white_check_mark: | img/**
| 540.16KB | - :white_check_mark: | app/**
| 194.99KB | -

Final result: :white_check_mark:

View report in BundleMon website ➡️

Current branch size history | Target branch size history